Skip to content

GH-117195: Avoid assertion error in object.__sizeof__#117220

Merged
markshannon merged 5 commits into
python:mainfrom
faster-cpython:object_sizeof_int
May 23, 2024
Merged

GH-117195: Avoid assertion error in object.__sizeof__#117220
markshannon merged 5 commits into
python:mainfrom
faster-cpython:object_sizeof_int

Conversation

@markshannon

@markshannon markshannon commented Mar 25, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Mar 25, 2024
Closed
Eclips4
Eclips4 reviewed Mar 25, 2024
View reviewed changes
Comment thread Lib/test/test_long.py Outdated
@markshannon markshannon added the needs backport to 3.13 bugs and security fixes label May 21, 2024
@markshannon markshannon merged commit 406ffb5 into python:main May 23, 2024
@miss-islington-app

miss-islington-app Bot commented May 23, 2024

Copy link
Copy Markdown

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 23, 2024
@markshannon @miss-islington
pythonGH-117195: Avoid assertion error in object.__sizeof__ (python…
465e366 
…GH-117220)

(cherry picked from commit 406ffb5)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-app

bedevere-app Bot commented May 23, 2024

Copy link
Copy Markdown

GH-119456 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label May 23, 2024
markshannon pushed a commit that referenced this pull request May 23, 2024
@miss-islington
[3.13] GH-117195: Avoid assertion error in object.__sizeof__ (GH-11…
251ef2e 
…7220) (GH-119456)
@JelleZijlstra JelleZijlstra mentioned this pull request May 28, 2024
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@markshannon @estyxx
pythonGH-117195: Avoid assertion error in object.__sizeof__ (python…
512e694 
…GH-117220)
@markshannon markshannon deleted the object_sizeof_int branch August 6, 2024 10:19
@vstinner vstinner added the needs backport to 3.12 only security fixes label Dec 4, 2024
@miss-islington-app

miss-islington-app Bot commented Dec 4, 2024

Copy link
Copy Markdown

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 4, 2024
@markshannon @miss-islington
pythonGH-117195: Avoid assertion error in object.__sizeof__ (python…
1ebe0e3 
…GH-117220)

(cherry picked from commit 406ffb5)

Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-app

bedevere-app Bot commented Dec 4, 2024

Copy link
Copy Markdown

GH-127605 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Dec 4, 2024
@vstinner

vstinner commented Dec 4, 2024

Copy link
Copy Markdown
Member

Python 3.12 is also affected by the issue: #127603.

vstinner pushed a commit that referenced this pull request Dec 11, 2024
@miss-islington @markshannon
[3.12] GH-117195: Avoid assertion error in object.__sizeof__ (GH-11…
0964f9f 
…7220) (#127605)

GH-117195: Avoid assertion error in `object.__sizeof__` (GH-117220)
(cherry picked from commit 406ffb5)

Co-authored-by: Mark Shannon <mark@hotpy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eclips4 Eclips4 Eclips4 left review comments

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon @vstinner @iritkatriel @Eclips4